ENH: Add support for PBR material properties in material property widgets #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gets ctkMaterialPropertyWidget can now edit material properties for both non-PBR (Phong, Gouraud) and PBR interpolation. PBR material properties are `diffuse` (shared with non-PBR modes) and `metallic` and `roughness` (matching names used in VTK and glTF). An interpolation mode selector is added (hidden by default for backward compatibility) to allow easy switching between interpolation modes. ctkVTKSurfaceMaterialPropertyWidget is updated to get/set associated properties in VTK. ctkMaterialPropertyPreviewLabel is updated so that it can display both PBR and non-PBR material settings. Preview of PBR settings is a rough approximation.
lassoan
force-pushed
the
pbr-material-properties
branch
from
8d3af09 to
1907195
Compare
pieper
approved these changes
Jan 31, 2022
| ambient = 0; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't think this preview does much good anyway - at least in Slicer you almost always have the live update of your model visible which is better than a sphere anyway. I'm pretty sure this code is a holdover from an old dialog, maybe even ported from Tcl.
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ctkMaterialPropertyWidget can now edit material properties for both non-PBR (Phong, Gouraud) and PBR interpolation.
PBR material properties are
diffuse(shared with non-PBR modes) andmetallicandroughness(matching names used in VTK and glTF).An interpolation mode selector is added (hidden by default for backward compatibility) to allow easy switching between interpolation modes.
ctkVTKSurfaceMaterialPropertyWidget is updated to get/set associated properties in VTK.
ctkMaterialPropertyPreviewLabel is updated so that it can display both PBR and non-PBR material settings. Preview of PBR settings is a rough approximation.
Example of PBR rendering in 3D Slicer: