Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Consistently export global and namespace symbols #1009

Merged
merged 1 commit into from
Nov 5, 2021
Merged

COMP: Consistently export global and namespace symbols #1009

merged 1 commit into from
Nov 5, 2021

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Nov 4, 2021 •
edited
Loading

* [ ] Update commit message with improved justification

@jcfr jcfr mentioned this pull request Nov 4, 2021
Merged
lassoan
lassoan approved these changes Nov 4, 2021
View reviewed changes
Copy link
Member

@lassoan lassoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jcfr jcfr merged commit 85c89cf into commontk:master Nov 5, 2021
@jcfr jcfr deleted the update-global-and-namespaced-export-convention branch November 5, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassoan lassoan lassoan approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcfr @lassoan