Replaced usage of NoPermissionsFragment with AlertDialog in NearbyActivity #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the NoPermissionsFragment, now an AlertDialog is shown providing options to either retry the permission request or cancel and quit the activity.
|
A screenshot of what the AlertDialog looks like:
|
Codecov Report
@@ Coverage Diff @@
## master #866 +/- ##
========================================
- Coverage 6.91% 6.9% -0.02%
========================================
Files 95 95
Lines 5018 5028 +10
Branches 471 471
========================================
Hits 347 347
- Misses 4644 4654 +10
Partials 27 27
Continue to review full report at Codecov.
|
|
Sorry it took so long to get back to you, @Bluesir9 ! I'm good with merging this once the conflicts have been resolved. |
|
@misaochan Have resolved the conflicts found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of NoPermissionsFragment when location run-time permission has been denied in NearbyActivity has been replaced with the usage of an AlertDialog providing the user actions to either retry the run-time permission again or cancel the request(in which case the user exits the NearbyActivity).