Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Java codegen #912

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Fixes for Java codegen #912

merged 2 commits into from
Jan 29, 2025

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Jan 29, 2025

  • java codegen: use double quotes for string literals in generated code.
  • java codegen: UnionLoader.alternates needs a concrete collection type.

@mr-c
Copy link
Member Author

mr-c commented Jan 29, 2025

Examples using CWL v1.2 & v1.2 schema is at common-workflow-language/cwljava#192

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.30%. Comparing base (6c06ff4) to head (c6d16be).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage   83.30%   83.30%           
=======================================
  Files          22       22           
  Lines        4949     4949           
  Branches     1185     1185           
=======================================
  Hits         4123     4123           
  Misses        548      548           
  Partials      278      278           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mr-c mr-c merged commit a37b186 into main Jan 29, 2025
24 checks passed
@mr-c mr-c deleted the java_codegen2025 branch January 29, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant