Improve class uri handling #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlassOfWhiskey
force-pushed
the
improve-namespaced-classes
branch
2 times, most recently
from
453d4c5 to
b6ab7a2
Compare
This commit simplifies handling full class uris in three ways. It removes the `class_uri` field and retrieves the full class uri directly from the `rvocab` data structure
GlassOfWhiskey
force-pushed
the
improve-namespaced-classes
branch
from
b6ab7a2 to
8bb8afb
Compare
GlassOfWhiskey
added a commit
to common-workflow-language/cwl-utils
that referenced
this pull request
Jan 28, 2025
This commit regenerates parsers after the fix for prefix handling during save introduced by common-workflow-language/schema_salad#911
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #911 +/- ##
==========================================
- Coverage 83.32% 83.30% -0.02%
==========================================
Files 22 22
Lines 4954 4949 -5
Branches 1187 1185 -2
==========================================
- Hits 4128 4123 -5
Misses 548 548
Partials 278 278 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies handling full class uris in three ways. It removes the
class_urifield and retrieves the full class uri directly from thervocabdata structure