java codegen: expose the extension fields #908
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mr-c
commented
Jan 16, 2025
•
mr-c
commented
- test with cwljava @vedran-kasalica
mr-c
force-pushed
the
java_extension_fields
branch
from
89353b9 to
8003f82
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #908 +/- ##
=======================================
Coverage 83.30% 83.30%
=======================================
Files 22 22
Lines 4949 4949
Branches 1185 1185
=======================================
Hits 4123 4123
Misses 548 548
Partials 278 278 ☔ View full report in Codecov by Sentry. |
mr-c
force-pushed
the
java_extension_fields
branch
from
8003f82 to
748354d
Compare
mr-c
force-pushed
the
java_extension_fields
branch
from
748354d to
8a666ce
Compare
|
@vedran-kasalica I fixed cwljava, and you can see the result of this change at common-workflow-language/cwljava#193 ; can you test it? |
|
@mr-c thank you for the update, I will work on the project and test it next week and let you know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.