Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The value of copyFrom.fetcher is not used in the LoadingOptions constructor in typescript #805

Closed
bioflowy opened this issue Mar 7, 2024 · 0 comments

Comments

@bioflowy
Copy link
Contributor

bioflowy commented Mar 7, 2024

The value of copyFrom.fetcher is not used in the LoadingOptions constructor in schema_salad/typescript/util/LoadingOptions.ts .

const original = new LoadingOptions({fetcher: new TestFetcher()})
it('should have the same Fetcher as the original', async () => {
   const copy = new LoadingOptions({copyFrom:original})
   assert.equal(copy.fetcher,original.fetcher)
})

This test fails.

bioflowy added a commit to bioflowy/schema_salad that referenced this issue Mar 7, 2024
…ot used in the LoadingOptions constructor in typescript
bioflowy added a commit to bioflowy/schema_salad that referenced this issue Mar 7, 2024
…ot used in the LoadingOptions constructor in typescript
mr-c pushed a commit to bioflowy/schema_salad that referenced this issue Apr 10, 2024
…ot used in the LoadingOptions constructor in typescript
@mr-c mr-c closed this as completed in 74a5ba5 Apr 10, 2024
giuseppe998e pushed a commit to giuseppe998e/schema_salad that referenced this issue Nov 7, 2024
…ot used in the LoadingOptions constructor in typescript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant