Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github-actions): fix release step tag name and use ncipollo/release-action@v1 #925

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Dec 3, 2023

Description

previously, we used a.b.c to create release instead of va.b.c. This PR fixed this issue and replace the outdated action with ncipollo/release-action@v1

Closes: #923

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Steps to Test This Pull Request

Additional context

@Lee-W Lee-W requested review from woile and noirbizarre December 3, 2023 05:04
Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (120d514) 97.33% compared to head (8dc3d09) 97.39%.
Report is 118 commits behind head on master.

Files Patch % Lines
commitizen/cli.py 82.14% 5 Missing ⚠️
commitizen/providers/scm_provider.py 91.17% 3 Missing ⚠️
commitizen/git.py 80.00% 2 Missing ⚠️
commitizen/changelog_formats/__init__.py 97.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #925      +/-   ##
==========================================
+ Coverage   97.33%   97.39%   +0.05%     
==========================================
  Files          42       55      +13     
  Lines        2104     2341     +237     
==========================================
+ Hits         2048     2280     +232     
- Misses         56       61       +5     
Flag Coverage Δ
unittests 97.39% <97.93%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Lee-W Lee-W merged commit 06e3b4c into master Dec 7, 2023
18 checks passed
@Lee-W Lee-W deleted the fix-release-actions branch December 7, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GitHub Actions] softprops/action-gh-release is still using "set-ouput" which might be deprecated soon
2 participants