Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conventional commits schema pattern #382

Merged
merged 3 commits into from
May 6, 2021
Merged

Fix conventional commits schema pattern #382

merged 3 commits into from
May 6, 2021

Conversation

shifqu
Copy link
Contributor

@shifqu shifqu commented May 6, 2021

Description

Adjust schema_pattern in cz_conventional_commits to match the conventional_commits spec

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

  • cz -n cz_conventional_commits check -m "feat!(scope): message" to fail validation
  • cz -n cz_conventional_commits check -m "feat(scope)!: message" to pass validation

Steps to Test This Pull Request

  1. Check out this branch
  2. Run commands as described in "Expected behaviour"

Additional context

#381

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #382 (e107411) into master (8638512) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #382      +/-   ##
==========================================
+ Coverage   97.60%   97.67%   +0.07%     
==========================================
  Files          39       39              
  Lines        1378     1378              
==========================================
+ Hits         1345     1346       +1     
+ Misses         33       32       -1     
Flag Coverage Δ
unittests 97.67% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...en/cz/conventional_commits/conventional_commits.py 100.00% <ø> (+1.58%) ⬆️
commitizen/__version__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6082b64...e107411. Read the comment docs.

@woile woile merged commit 5d8bc74 into commitizen-tools:master May 6, 2021
@shifqu shifqu deleted the fix-convetional-commits-schema-pattern branch May 6, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants