Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changeset: Remove. node 16 support #896

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Conversation

lojzatran
Copy link
Contributor

I forgot to add the changeset for nodejs 16 support removal.

@lojzatran lojzatran requested a review from a team as a code owner January 7, 2025 19:21
Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 250befb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@commercetools/importapi-sdk Major
@commercetools/ts-client Major
@commercetools/platform-sdk Major
@commercetools/history-sdk Major
@commercetools/sdk-client-v2 Major
@commercetools/ts-sdk-apm Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lojzatran lojzatran changed the title Remove. node 16 support changeset: Remove. node 16 support Jan 7, 2025
@ajimae
Copy link
Contributor

ajimae commented Jan 7, 2025

Nice 👍🏽

I just noticed

  • the engines section of the package.json file were not updated, is it possible to update it to say "node": >="18" in this PR?
  • and the ts-sdk-apm package wasn't included in the changeset, was there any reason for this?

Thank you 🙏🏽

@lojzatran
Copy link
Contributor Author

Nice 👍🏽

I just noticed

  • the engines section of the package.json file were not updated, is it possible to update it to say "node": >="18" in this PR?
  • and the ts-sdk-apm package wasn't included in the changeset, was there any reason for this?

Thank you 🙏🏽

Good catch 🐛 I fixed it: 250befb

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.05%. Comparing base (f24219d) to head (250befb).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #896   +/-   ##
=======================================
  Coverage   93.05%   93.05%           
=======================================
  Files          25       25           
  Lines         288      288           
  Branches       14       14           
=======================================
  Hits          268      268           
  Misses         20       20           
Flag Coverage Δ
integrationtests 93.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lojzatran lojzatran requested a review from ajimae January 8, 2025 08:36
Copy link
Contributor

@ajimae ajimae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lojzatran lojzatran merged commit f9b8cb6 into master Jan 8, 2025
6 checks passed
@lojzatran lojzatran deleted the remove_node_16_support branch January 8, 2025 09:17
@ct-changesets ct-changesets bot mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants