Trim whitespace from file contents #186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
file
matcher I added last year doesn't trim whitespace, whereas the executors do trim whitespace from the content they capture from stdout and stderr. This causes annoyance if you edit the "gold" file with an editor like Vim that automatically appends a newline. I also changed it to convert\r\n
to\n
to match the executors.Checklist
Linux
,Windows
andmacOS
?