Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix windows unit test #172

Merged
merged 1 commit into from
Apr 19, 2021
Merged

fix windows unit test #172

merged 1 commit into from
Apr 19, 2021

Conversation

dylanhitt
Copy link
Member

Fixes #

Checklist

  • Added unit / integration tests for windows, macOS and Linux?
  • Added a changelog entry in CHANGELOG.md?
  • Updated the documentation (README.md, docs)?
  • Does your change work on Linux, Windows and macOS?

@dylanhitt dylanhitt force-pushed the fix-windows-integration branch from f125e71 to bf615d2 Compare April 18, 2021 23:47
@dylanhitt dylanhitt changed the title fix windows integration test fix windows unit test Apr 18, 2021
@dylanhitt dylanhitt requested a review from SimonBaeumer April 18, 2021 23:52
@dylanhitt dylanhitt force-pushed the fix-windows-integration branch 3 times, most recently from 534b78a to 7bce66e Compare April 18, 2021 23:55
@dylanhitt dylanhitt force-pushed the fix-windows-integration branch from 7bce66e to 9a333ee Compare April 18, 2021 23:56
@dylanhitt
Copy link
Member Author

dylanhitt commented Apr 19, 2021 •
edited
Loading

@SimonBaeumer, something interesting I noticed with this fix. It seems the current executor isn't based on the shell you're running commander from. For example this test failed because I was expecting the execution environment to be powershell. It appears to be CMD on windows.

Should we provide a way to specify the execution env with a flag? Or better yet we interpret he execution environment?

@SimonBaeumer
Copy link
Member

@dylanhitt you are right, sorry about that. The PR looks good to me!
Hm, I would agree but the problem with Windows tests are more the environment it runs in (here CircleCI) and the tooling available.
If you want to add it and need it feel free to do so. 👍

@SimonBaeumer SimonBaeumer merged commit fe62a17 into master Apr 19, 2021
@dylanhitt dylanhitt deleted the fix-windows-integration branch February 25, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonBaeumer SimonBaeumer SimonBaeumer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanhitt @SimonBaeumer