Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump verion to v2 #171

Merged
merged 1 commit into from
Apr 18, 2021
Merged

bump verion to v2 #171

merged 1 commit into from
Apr 18, 2021

Conversation

dylanhitt
Copy link
Member

@dylanhitt dylanhitt commented Apr 9, 2021

Fixes #166

It appears with the introduction of go modules you're required to version in go.mod. The guys over at golang/go do a way better job explaining this than I will.

The following works:

$ docker run -it golang:1.16 bash
root@6b1de3212ce1:/go# go get github.com/commander-cli/commander/v2/cmd/commander@bump-go-mod-version 
go: downloading github.com/commander-cli/commander/v2 v2.4.1-0.20210409193347-b7852b522732
go: downloading github.com/urfave/cli v1.22.5
go: downloading github.com/commander-cli/cmd v1.3.0
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading github.com/logrusorgru/aurora v2.0.3+incompatible
go: downloading github.com/docker/docker v1.13.1
go: downloading golang.org/x/crypto v0.0.0-20210322153248-0c34fe9e7dc2
go: downloading github.com/antchfx/xmlquery v1.3.5
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/tidwall/gjson v1.7.1
go: downloading github.com/stretchr/testify v1.7.0
go: downloading github.com/cpuguy83/go-md2man/v2 v2.0.0-20190314233015-f79a8a8ca69d
go: downloading github.com/antchfx/xpath v1.1.10
go: downloading github.com/golang/groupcache v0.0.0-20200121045136-8c9f03a8e57e
go: downloading golang.org/x/net v0.0.0-20210226172049-e18ecbb05110
go: downloading github.com/tidwall/match v1.0.3
go: downloading github.com/tidwall/pretty v1.1.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c
go: downloading github.com/russross/blackfriday/v2 v2.0.1
go: downloading golang.org/x/text v0.3.3
go: downloading github.com/docker/go-connections v0.4.0
go: downloading github.com/docker/go-units v0.4.0
go: downloading golang.org/x/sys v0.0.0-20201119102817-f84b799fce68
go: downloading github.com/docker/distribution v2.7.1+incompatible
go: downloading github.com/pkg/errors v0.9.1
go: downloading github.com/shurcooL/sanitized_anchor_name v1.0.0
go: downloading github.com/opencontainers/go-digest v1.0.0
go: downloading github.com/Microsoft/go-winio v0.4.16
root@6b1de3212ce1:/go#

I'm unsure if this will require any other changes such as our badges?? Or really anything for that matter.

@dylanhitt dylanhitt requested a review from SimonBaeumer April 9, 2021 20:01
@dylanhitt dylanhitt force-pushed the bump-go-mod-version branch from 51be63d to 7bc8f46 Compare April 9, 2021 20:05
@SimonBaeumer
Copy link
Member

Nice thank you!
Imho you can rebase and merge it :)

@dylanhitt dylanhitt mentioned this pull request Apr 16, 2021
4 tasks
@dylanhitt dylanhitt force-pushed the bump-go-mod-version branch from 7bc8f46 to 7d79393 Compare April 17, 2021 18:21
@dylanhitt dylanhitt merged commit 5ad2aad into master Apr 18, 2021
@dylanhitt dylanhitt deleted the bump-go-mod-version branch April 18, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

documented install command fails with go 1.16
2 participants