Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to circleci #161

Merged
merged 3 commits into from
Jan 8, 2021
Merged

Move to circleci #161

merged 3 commits into from
Jan 8, 2021

Conversation

SimonBaeumer
Copy link
Member

@SimonBaeumer SimonBaeumer commented Dec 30, 2020

Fixes #160

  • macOS build is disabled, on circle CI it needs a subscription
  • go integration tests now run in docker with ./test.sh or using its make target make test-coverage-all-dockerized
    • this was necessary because circle CI does not support docker port-forwarding
    • decided against docker-compose because the test container would directly exit or needs to wait

Checklist

  • Added unit / integration tests for windows, macOS and Linux?
  • Added a changelog entry in CHANGELOG.md?
  • Updated the documentation (README.md, docs)?
  • Does your change work on Linux, Windows and macOS?

@codeclimate
Copy link

codeclimate bot commented Dec 30, 2020

Code Climate has analyzed commit 32955cb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 92.4% (0.0% change).

View more on Code Climate.

@SimonBaeumer
Copy link
Member Author

@dylanhitt would like to have your review on this. windows builds are capped, but I think it is acceptable given this is a small open source project 👍

@SimonBaeumer SimonBaeumer marked this pull request as ready for review January 5, 2021 22:02
Copy link
Member

@dylanhitt dylanhitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, I got to learn quite a bit from this 😄 . I'm not concerned about not being able to test macOS. If we run into a problem with it later we can discuss some possible solutions.

You mentioned windows being capped? I can't really find that in their docs. If so how may windows builds do we get per X time frame?

commander-int-ssh-server

docker build -t commander-int-test -f integration/containers/test/Dockerfile .
docker run \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can always add docker run --rm here. Avoiding some of the code below. But, you probably have a valid reason for not doing so

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just forgot it :D
Added --rm, time shows how this container evolves. If it is used more often it definitely needs to change and cached.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove lines, 40 and 41 as well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, done

@SimonBaeumer
Copy link
Member Author

I am not sure as well how much windows test capacity circleci provides.
Given the builds would be broken for an entire week because the credits are exhausted the windows tests should only be executed on master branch and release tags.

@dylanhitt
Copy link
Member

dylanhitt commented Jan 7, 2021

Actually looking into it more, it appears we're capped out completely. The 2500 credits are for both linux/windows. The windows jobs are taking a little under 200 credits per run... Maybe we can still test on windows circle does have the ability to only build on pull request. But then we wouldn't be building on the branch 🤷.

Honestly, I'm fine with not running windows jobs except for master/tag. We could possibly add some type of branching exception if we need it for debugging like win-<name>. I could also always break out my windows machine 🙃.

@SimonBaeumer
Copy link
Member Author

@dylanhitt looks better on the linux side:


Organizations on our free plan get 400,000 free credits per month ($2,880 annual value) to use for Linux open source builds. Enabling this will allow this project’s builds to use them and let others see your builds, both through the web UI and the API.

Therefore we can execute windows build just on master & tags that we do not release broken versions for windows.
Enabled your suggestion to only build on PRs, which is okay imho, if I do not create a pull request it is not that of a good PR anyways :D

Copy link
Member

@dylanhitt dylanhitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, again let's see how it goes.

@SimonBaeumer SimonBaeumer merged commit 80f1c54 into master Jan 8, 2021
@dylanhitt dylanhitt deleted the add-circleci branch April 9, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move away from travisCI
2 participants