Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Remove validator set change query from block_search endpoint examples #3266

Closed
dasanchez opened this issue Jun 14, 2024 · 1 comment · Fixed by #3399
Closed

[docs] Remove validator set change query from block_search endpoint examples #3266

dasanchez opened this issue Jun 14, 2024 · 1 comment · Fixed by #3399
Assignees
@melekes
Labels
bug Something isn't working documentation Improvements or additions to documentation rpc
Milestone
2024-Q3

Comments

@dasanchez
Copy link
Contributor

dasanchez commented Jun 14, 2024 •
edited
Loading

Hi! The block_search endpoint has examples listed here:

They list both a val_set.num_changed > 0 and a valset.changed > 0 query, but neither seems to work with Gaia v17.2.0 (CometBFT v0.37.6).
Are these queries still active, or have they been deprecated?

A delegation went through at height 6884760 in the ICS testnet, triggering a valset change:

curl -s "https://rpc.provider-sentry-01.ics-testnet.polypore.xyz/block_results?height=6884760" | jq '.result.validator_updates | length'
1

If I try to search for that block using the valset.changed>0 query with block_search, I don't get the 6884760 block in the results:

curl -s "https://rpc.provider-sentry-01.ics-testnet.polypore.xyz/block_search?query=\"block.height>6884759%20AND%20block.height<6884761\"" | jq '.result.total_count' 
"1"

curl -s "https://rpc.provider-sentry-01.ics-testnet.polypore.xyz/block_search?query=\"block.height>6884759%20AND%20block.height<6884761%20AND%20valset.changed>0\"" | jq '.result.total_count'
"0"

Thanks!
@cason cason added bug Something isn't working needs-triage This issue/PR has not yet been triaged by the team. labels Jun 26, 2024
@melekes melekes self-assigned this Jul 2, 2024
melekes added a commit that referenced this issue Jul 2, 2024
@melekes
docs: remove not existing key from block search query
0ee3f43 
Closes #3266
@melekes melekes mentioned this issue Jul 2, 2024
Merged
4 tasks
@melekes
Copy link
Contributor

melekes commented Jul 2, 2024

Thanks for flagging this 👍 We don't have a key like that in CometBFT (at least not presently).

For Cosmos SDK events, please see https://docs.cosmos.network/v0.50/learn/advanced/events and https://docs.cosmos.network/v0.50/build/modules/staking#events.

@andynog andynog added this to CometBFT Jul 2, 2024
@github-project-automation github-project-automation bot moved this to Todo in CometBFT Jul 2, 2024
@andynog andynog moved this from Todo to Ready for Review in CometBFT Jul 2, 2024
@andynog andynog moved this from Ready for Review to Approved in CometBFT Jul 2, 2024
@andynog andynog added this to the 2024-Q3 milestone Jul 2, 2024
@andynog andynog added documentation Improvements or additions to documentation rpc and removed needs-triage This issue/PR has not yet been triaged by the team. labels Jul 2, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 3, 2024
@melekes @andynog
docs: remove not existing key from block search query (#3399)
8f659c5 
Closes #3266

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [ ] ~~Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

Co-authored-by: Andy Nogueira <[email protected]>
@github-project-automation github-project-automation bot moved this from Approved to Done in CometBFT Jul 3, 2024
mergify bot pushed a commit that referenced this issue Jul 3, 2024
@melekes @mergify
docs: remove not existing key from block search query (#3399)
a1bffbe 
Closes #3266

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [ ] ~~Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

Co-authored-by: Andy Nogueira <[email protected]>
(cherry picked from commit 8f659c5)
@mergify mergify bot mentioned this issue Jul 3, 2024
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Jul 3, 2024
@melekes @mergify
docs: remove not existing key from block search query (#3399)
5615e6e 
Closes #3266

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [ ] ~~Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

Co-authored-by: Andy Nogueira <[email protected]>
(cherry picked from commit 8f659c5)
@mergify mergify bot mentioned this issue Jul 3, 2024
Merged
4 tasks
mergify bot pushed a commit that referenced this issue Jul 3, 2024
@melekes @mergify
docs: remove not existing key from block search query (#3399)
bb99cb0 
Closes #3266

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [ ] ~~Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

Co-authored-by: Andy Nogueira <[email protected]>
(cherry picked from commit 8f659c5)
@mergify mergify bot mentioned this issue Jul 3, 2024
Merged
4 tasks
melekes added a commit that referenced this issue Jul 3, 2024
@mergify @melekes
docs: remove not existing key from block search query (backport #3399) (
b56beec 
#3408)

Closes #3266



---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [ ] ~~Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request #3399 done by
[Mergify](https://mergify.com).

Co-authored-by: Anton Kaliaev <[email protected]>
melekes added a commit that referenced this issue Jul 3, 2024
@mergify @melekes
docs: remove not existing key from block search query (backport #3399) (
eea0ec1 
#3409)

Closes #3266



---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [ ] ~~Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request #3399 done by
[Mergify](https://mergify.com).

Co-authored-by: Anton Kaliaev <[email protected]>
melekes added a commit that referenced this issue Jul 3, 2024
@mergify @melekes
docs: remove not existing key from block search query (backport #3399) (
3f43881 
#3410)

Closes #3266



---

#### PR checklist

- [ ] ~~Tests written/updated~~
- [ ] ~~Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)~~
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
<hr>This is an automatic backport of pull request #3399 done by
[Mergify](https://mergify.com).

Co-authored-by: Anton Kaliaev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melekes melekes

Labels
bug Something isn't working documentation Improvements or additions to documentation rpc
Projects
CometBFT
Status: Done
Milestone
2024-Q3
Development

Successfully merging a pull request may close this issue.

docs: remove not existing key from block search query cometbft/cometbft
4 participants
@cason @melekes @dasanchez @andynog