chore: Sync with upstream #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clepski
commented
Mar 4, 2025
•
clepski
commented
- Sync with upstream open scd 0.38.0
…LNType within a function (openscd#1595)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* chore: Raise core version to 0.1.4 * chore: Bump uploard-artifact to v4
* Added ADR-0003 - Externalize OpenSCD core plugins * Added ADR-0004 - Technical solution for releasing and deployments
* create workflow for attaching files * feat: attach core and plugin docs to build --------- Co-authored-by: Sergio Alvarenga <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Sergio Alvarenga <[email protected]>
* feat: change github actions workflow trigger * feat: trigger release-please only after release * chore: release 0.37.1 Release-As: 0.37.1 --------- Co-authored-by: Sergio Alvarenga <[email protected]>
* chore: release 0.37.2 Release-As: 0.37.2 --------- Co-authored-by: Sergio Alvarenga <[email protected]>
* chore: release 0.37.2 Release-As: 0.37.2 * chore: release 0.37.2 Release-As: 0.37.2 --------- Co-authored-by: Sergio Alvarenga <[email protected]>
* feat: update release please action --------- Co-authored-by: Sergio Alvarenga <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
salvar3nga
reviewed
Mar 7, 2025
| const positionList = <Select>( | ||
| this.pluginDownloadUI.querySelector('#menuPosition') | ||
| ); | ||
| // currently we only handley key shortcuts when users press ctrl |
There was a problem hiding this comment.
this is copied from open-scd, we should fix it in the upstream
salvar3nga
previously approved these changes
Mar 7, 2025
| import type { UserInfoEvent } from '../compas/foundation'; | ||
|
|
||
| import { HistoryState } from '@openscd/open-scd/src/addons/History.js'; |
There was a problem hiding this comment.
Not really related to the changes however, my vsc is hinting at multiple imports that aren't being used
| }) | ||
| ); | ||
| const topMenu = this.generateMenu(this.topMenu, 'top'); | ||
| const middleMenu = this.generateMenu(this.middleMenu, 'middle'); |
salvar3nga
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.