Separate resolvedRunIvyDeps and transitiveLocalClasspath into two stages when build assembly jar
#4565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lihaoyi
changed the title
resolvedRunIvyDeps and transitiveLocalClasspath into two stages when build assembly jar
lefou
reviewed
Feb 15, 2025
Comment on lines
+66
to
+68
| def upstreamIvyAssemblyClasspath: T[Seq[PathRef]] | ||
|
|
||
| def upstreamLocalAssemblyClasspath: T[Seq[PathRef]] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4564
This makes it such that changes to upstream modules can avoid re-assembling all the external thirdparty dependencies, whereas previously only changes to the exact module running
.assemblywould benefitTested manually via
/Users/lihaoyi/Github/mill/mill-assembly.jar -w integration.assemblyinexample/javalib/web/3-todo-springboot/.src/would take ~20s, becauseintegrationwas a downstream module of the rootbuildand so it wouldn't benefit from incremental assembly construction.resolvedIvyAssembly.dest/out.jarcontaining the bulk of the Spring classfiles before adding transitive local classpath and then the module's own local classpath, and incremental updates take ~1s