Backport "Consolidate jvm subprocess and inprocess functions (#4456)" to 0.12 #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - added functions based on com-lihaoyi#3772 description - the process related ones now return os-lib process result or subprocess handle - `callClassLoader` uses a loan pattern function and closes the classloader after usage - added `mill.util.ProcessUtil.toResult(processResult)` to handle process result in same way https://github.com/com-lihaoyi/mill/blob/main/main/util/src/mill/util/Jvm.scala#L352-L357 Some minor questions/suggestions: 1. current `spawnClassloader` is more flexible, you can pass your own classloader rather that use `getClass.getClassLoader`, this is ok I guess? 1. suggestion to name `spawnClassLoader` as `createClassLoader` 1. suggestion to name `callClassloader` as `withClassloader` (common loan pattern name) 1. `getMainMethod` is not public so `runLocal` can't be removed.. so expose `getMainMethod` or leave `runLocal` as is? 1. Some calls are inside build.mill files. I have to wait for new version of Mill with these changes included, and then update them? 1. Not sure if `closeClassLoaderWhenDone` is needed, I don't understand why it is left unclosed in few places. Closes com-lihaoyi#3772 --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #4456