Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of Android Support: screenshot testing #4411

Merged
merged 8 commits into from
Jan 29, 2025
Merged

Part of Android Support: screenshot testing #4411

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
25e715d
screenshot test experimental
irodotos7 Jan 23, 2025
20553fc
docs
vaslabs Jan 27, 2025
2969f96
Working example
vaslabs Jan 27, 2025
b7201a4
fmt
vaslabs Jan 27, 2025
00d20ef
Cosmetics
vaslabs Jan 27, 2025
8f4f749
Merged with main
vaslabs Jan 29, 2025
b62c217
Added more docs
vaslabs Jan 29, 2025
a46eddd
Cosmetics
vaslabs Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cosmetics
  • Loading branch information
@vaslabs
vaslabs committed Jan 27, 2025
commit 00d20efbcfb79311ade39271dcfaca0855e5d9ec
6 changes: 3 additions & 3 deletions scalalib/src/mill/javalib/android/AndroidAppModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import mill.define.{ModuleRef, Task}
import mill.scalalib.bsp.BspBuildTarget
import mill.testrunner.TestResult
import mill.util.Jvm
import os.{Path, RelPath}
import os.RelPath
import upickle.default._

import scala.jdk.OptionConverters.RichOptional
Expand Down Expand Up @@ -228,13 +228,13 @@ trait AndroidAppModule extends JavaModule {
extractAarFiles(aarFiles.toSeq, Task.dest)
}

final def extractAarFiles(aarFiles: Seq[Path], taskDest: os.Path): Seq[UnpackedDep] = {
final def extractAarFiles(aarFiles: Seq[os.Path], taskDest: os.Path): Seq[UnpackedDep] = {
aarFiles.map(aarFile => {
val extractDir = taskDest / aarFile.baseName
os.unzip(aarFile, extractDir)
val name = aarFile.baseName

def pathOption(p: Path): Option[PathRef] = if (os.exists(p)) {
def pathOption(p: os.Path): Option[PathRef] = if (os.exists(p)) {
Some(PathRef(p))
} else None

Expand Down
Loading