Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first class Javascript/Typescript support to the Mill build tool #4398

Merged
merged 25 commits into from
Jan 29, 2025

Conversation

monyedavid
Copy link
Contributor

@monyedavid monyedavid commented Jan 24, 2025

This pr implements the examples for jslib/dependencies.

#3927

Checklist:

  • example/jslib/linting
    • 1-linting
    • 2-autoformatting
    • 3-code-coverage

Key changes:

  • Add coverage for Jest, Jasmine, Mocha and Vitest.
  • Add lint and auto format support with prettier and eslint.
  • Generate test config for Jest & Vite, with option to use a custom test config.

@lihaoyi
Copy link
Member

lihaoyi commented Jan 27, 2025

The docs for Linting and AutoFormatting with Eslint and Prettier appears to be duplicated twice

Linting Typescript Projects __ The Mill JVM Build Tool.pdf

@lihaoyi
Copy link
Member

lihaoyi commented Jan 27, 2025

Is there a reason example/javascriptlib/testing/1-test-suite/vite.config.ts and all the other files was deleted?

@monyedavid
Copy link
Contributor Author

monyedavid commented Jan 27, 2025

Is there a reason example/javascriptlib/testing/1-test-suite/vite.config.ts and all the other files was deleted?

yes, mill generates by default those files... but you can opt to use yours. I will update the testing docs.

@monyedavid
Copy link
Contributor Author

The docs for Linting and AutoFormatting with Eslint and Prettier appears to be duplicated twice

Linting Typescript Projects __ The Mill JVM Build Tool.pdf

will clean out the auto-format docs

@monyedavid monyedavid requested a review from lihaoyi January 28, 2025 09:54
@monyedavid
Copy link
Contributor Author

@lihaoyi this is still pending completion.

@lihaoyi lihaoyi merged commit da80000 into com-lihaoyi:main Jan 29, 2025
31 checks passed
@lefou lefou added this to the 0.12.6 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants