Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segments.last: Fix error message #4391

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Segments.last: Fix error message #4391

merged 2 commits into from
Jan 24, 2025

Conversation

nafg
Copy link
Contributor

@nafg nafg commented Jan 24, 2025

No description provided.

@lihaoyi
Copy link
Member

lihaoyi commented Jan 24, 2025

Thank @nafg !

@lihaoyi lihaoyi marked this pull request as ready for review January 24, 2025 01:57
@lihaoyi lihaoyi merged commit 1c9f6c4 into com-lihaoyi:main Jan 24, 2025
13 of 16 checks passed
@nafg nafg deleted the patch-2 branch January 24, 2025 01:58
@lefou
Copy link
Member

lefou commented Jan 24, 2025

Can that be right? We need segments to start with a label, but ending with a cross is perfectly fine.

@lefou
Copy link
Member

lefou commented Jan 24, 2025

Looks like Segments.last was only introduced recently in #4132. We should review whether it really needs to be a Label, or if it being a Cross would be ok too.

@lefou lefou added the post-review-required A merged PR which has still open comments or questions, which need to be clarified label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
post-review-required A merged PR which has still open comments or questions, which need to be clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nafg @lihaoyi @lefou