New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add first class Javascript/Typescript support to the Mill build tool #4293

Merged

lihaoyi merged 12 commits into com-lihaoyi:main from monyedavid:3927/jslib-publish

Jan 16, 2025

Contributor

monyedavid commented Jan 12, 2025 •

edited

Loading

This pr implements the examples for jslib/dependencies.

Checklist:

example/jslib/publish
- 1-publish
- 2-realistic

Key changes:

Packages can now be imported without the node_modules prefix.
PublishMeta - package.json (for publish) generation
Prepare js code for publishing in publish directory

monyedavid added 3 commits

January 12, 2025 02:45


          example/javascriptlib/publishing


          fix failing errors

14ad8af


          fix failing

8b52091

lihaoyi reviewed

View reviewed changes

example/javascriptlib/publishing/2-realistic/build.mill Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

example/javascriptlib/publishing/2-realistic/build.mill Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

example/javascriptlib/publishing/2-realistic/build.mill Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

example/javascriptlib/publishing/2-realistic/build.mill Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

main/package.mill Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/TypeScriptModule.scala Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Outdated Show resolved Hide resolved

lihaoyi reviewed

View reviewed changes

javascriptlib/src/mill/javascriptlib/PublishModule.scala Outdated Show resolved Hide resolved

He-Pin reviewed

View reviewed changes

build.mill Outdated Show resolved Hide resolved


          requested changes

ac9a445

monyedavid requested a review from lihaoyi

January 13, 2025 08:51

monyedavid added 4 commits

January 13, 2025 10:04


          fix lint

9195edc


          requested changes:

3f7e0ef

- use os.symlink


          fix doc

c362af9


          minor edit

72b3857

monyedavid added 4 commits

January 16, 2025 08:00


          minor edit

a4bd5db


          add pub link to navbar

0e6d1d1


          fix doc

fa54cc2


          Merge branch 'main' into 3927/jslib-publish

293ee02

# Conflicts:
#	example/package.mill
#	javascriptlib/package.mill

Member

lihaoyi commented Jan 16, 2025

I think this looks great, thanks @monyedavid

lihaoyi merged commit e1f43c5 into com-lihaoyi:main

28 checks passed

lefou added this to the 0.12.6 milestone

irodotos7 pushed a commit to vaslabs-ltd/mill that referenced this pull request


          Add first class Javascript/Typescript support to the Mill build tool (c…

1c5a7c0

…om-lihaoyi#4293)

This pr implements the examples for jslib/dependencies.

com-lihaoyi#3927

Checklist:
- [x] **example/jslib/publish**
     - [x]  1-publish
     - [x]  2-realistic
     
Key changes:
- Packages can now be imported without the node_modules prefix.
- PublishMeta - package.json (for publish) generation
- Prepare js code for publishing in publish directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet