Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update utest to 0.8.5 #4284

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Conversation

scala-steward
Copy link
Contributor

About this PR

πŸ“¦ Updates com.lihaoyi:utest from 0.8.4 to 0.8.5

πŸ“œ GitHub Release Notes - Version Diff

Usage

βœ… Please merge!

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

πŸ” Files still referring to the old version number

The following files still refer to the old version number (0.8.4).
You might want to review and update them manually.

integration/ide/gen-idea/resources/hello-idea/idea/mill_modules/helloideajs.test.iml
readme.adoc
scalalib/test/src/mill/scalalib/ScalaMultiModuleClasspathsTests.scala
βš™ Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "com.lihaoyi", artifactId = "utest" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequests = { frequency = "30 days" },
  dependency = { groupId = "com.lihaoyi", artifactId = "utest" }
}]
labels: library-update, early-semver-minor, semver-spec-patch, old-version-remains, commit-count:1

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the last failing CI test (something "mockito") is unrelated to this bump.

@lihaoyi
Copy link
Member

lihaoyi commented Jan 24, 2025

yeah that mockito test seems to have gotten super flaky suddenly, not sure why

@lihaoyi lihaoyi merged commit 2caff49 into com-lihaoyi:main Jan 24, 2025
30 of 31 checks passed
@lefou
Copy link
Member

lefou commented Jan 24, 2025

@lihaoyi How do you merge nowadays? I don't find my co-authorship in the final commit of this PR. Although Github should generate it properly when you squash-merge via the UI buttons. It's not that problematic in this case, but in general, if we squash and erase all traces of the work that lead to a change, we should at least use the appropriate git capabilities to attribute authorship.

@lihaoyi
Copy link
Member

lihaoyi commented Jan 24, 2025

@lefou I've just been using the squash-and-merge button on github.

@lefou
Copy link
Member

lefou commented Jan 24, 2025

Maybe, you manually removed the lengthy commit message body that Scala Steward generated (as I do it) and overlooked that there was a Co-authored-by: line at the end?

Since I'm missing myself as author also in some other commits in this repo, I'd like to remind everyone, that we should take authorship not lightly! Beside being just fair, especially in Open Source projects based on voluntary contributions, I often use this info later, when digging something up in history. It can become frustrating if you can't find a change you made, just because all traces that you made that change are gone.

@lihaoyi
Copy link
Member

lihaoyi commented Jan 24, 2025

Oh yes I've been removing the long commit message body for these scala steward commits. I can try to leave the co-authored-by suffix next time

@lefou lefou added this to the 0.12.6 milestone Jan 24, 2025
gamlerhart pushed a commit to gamlerhart/mill that referenced this pull request Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants