-
-
Notifications
You must be signed in to change notification settings - Fork 393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update utest to 0.8.5 #4284
Update utest to 0.8.5 #4284
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the last failing CI test (something "mockito") is unrelated to this bump.
yeah that mockito test seems to have gotten super flaky suddenly, not sure why |
@lihaoyi How do you merge nowadays? I don't find my co-authorship in the final commit of this PR. Although Github should generate it properly when you squash-merge via the UI buttons. It's not that problematic in this case, but in general, if we squash and erase all traces of the work that lead to a change, we should at least use the appropriate git capabilities to attribute authorship. |
@lefou I've just been using the squash-and-merge button on github. |
Maybe, you manually removed the lengthy commit message body that Scala Steward generated (as I do it) and overlooked that there was a Since I'm missing myself as author also in some other commits in this repo, I'd like to remind everyone, that we should take authorship not lightly! Beside being just fair, especially in Open Source projects based on voluntary contributions, I often use this info later, when digging something up in history. It can become frustrating if you can't find a change you made, just because all traces that you made that change are gone. |
Oh yes I've been removing the long commit message body for these scala steward commits. I can try to leave the co-authored-by suffix next time |
About this PR
π¦ Updates com.lihaoyi:utest from
0.8.4
to0.8.5
π GitHub Release Notes - Version Diff
Usage
β Please merge!
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a
.scala-steward.conf
file.Have a fantastic day writing Scala!
π Files still referring to the old version number
The following files still refer to the old version number (0.8.4).
You might want to review and update them manually.
β Adjust future updates
Add this to your
.scala-steward.conf
file to ignore future updates of this dependency:Or, add this to slow down future updates of this dependency: