Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ignoreErrors = true to make clean work on runBackground subprocesses on windows #4265

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jan 8, 2025

fixes #4260

With ignoreErrors = true, we ignore the .mill-background-process-lock file, and proceed to delete the .mill-background-process-uuid file, which is enough to make the process exit even if the un-used lock file is hanging around after

@lihaoyi lihaoyi marked this pull request as ready for review January 8, 2025 02:33
@lihaoyi lihaoyi merged commit 775451f into com-lihaoyi:main Jan 8, 2025
25 of 26 checks passed
@lefou lefou added this to the 0.12.6 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean does not terminate runBackground subprocess on Windows
2 participants