Replace waiting for android emulator with a sleep and a list device call to verify emulator is running #4261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to replicate why the timeouts related to the android emulator that happen in github actions. It seems that the
adb wait-for-device
is stuck although I cannot replicate it locally and the kotlin example does not suffer the same issue.So for now, I added some wait time after start emulator and a call to
adb device
to verify the device is indeed present and it seems to be working.This should work for the time being and make the job green until we create a better alternative.
Small change included: Since we throw an error if we don't detect the boot notification of start emulator, I changed the
startAndroidEmulator
signature fromOption[String]
toString
Linking the green job on my copy for reference: https://github.com/vaslabs-ltd/mill/actions/runs/12651834850/job/35253442650