Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first class Javascript/Typescript support to the Mill build tool #4253

Merged
merged 12 commits into from
Jan 7, 2025

Conversation

monyedavid
Copy link
Contributor

This pr implements the examples for jslib/dependencies.

#3927

Checklist:

  • example/jslib/testing
    • 3-integration-suite-cypress
    • 3-integration-suite-playwright

@monyedavid monyedavid force-pushed the 3927/jslib-integration-suite branch from 8ad50cc to 6482241 Compare January 6, 2025 04:46
@lihaoyi
Copy link
Member

lihaoyi commented Jan 6, 2025

I think at a high level, this example needs to be significantly shortened. Let's trim all the CSS, robots.txt, logos, all the boilerplate comments from the .html files: just leave a JS server, JS client, and the integration tests.

This example doesn't need to be realistic, since there are other examples in the javascriptlib/ folder that show the other parts, so we can just focus on the core of how the integration tests are wired up and written

- kill boilerplate code
- kill boilerplate code; use express server
@monyedavid monyedavid requested a review from lihaoyi January 6, 2025 18:04
- kill boilerplate code; remove css files
use different test port for playwright & cypress
- specify chromium browser for playwright
@monyedavid
Copy link
Contributor Author

monyedavid commented Jan 7, 2025

@lihaoyi are you aware mill can no longer handle special characters?

when matching: typescript/src/server/playwright/app.test.ts:4:9 › React App › displays the heading...
the amongst others will throw an error causing a failed matched. I am positive at some point that would work as expected.

-- Edit:
Not sure if its a mill problem, but it works fine in local environment

failing match
failing match
@lihaoyi
Copy link
Member

lihaoyi commented Jan 7, 2025

I think this looks good, thanks!

@lihaoyi lihaoyi merged commit 31d03bb into com-lihaoyi:main Jan 7, 2025
25 of 26 checks passed
@lefou lefou added this to the 0.12.6 milestone Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants