Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up mill process in LauncherOldVersionTests to prevent test report failures #4251

Merged
merged 8 commits into from
Jan 6, 2025

Conversation

lihaoyi
Copy link
Member

@lihaoyi lihaoyi commented Jan 6, 2025

Previously the leftover running mill processes caused action-junit-report to fail when it tried to walk the out\mill-worker-uyUCkqx6lYTWawU0H+fOCWvQ\u8=-1\mill-093bdc52daae5837bacc1b1b565ee261-io file in the sandbox directory

Fixes errors such as

Run mikepenz/action-junit-report@v5
📘 Reading input values
📦 Process test results
  Preparing 1 report as configured.
  Error: EACCES: permission denied, lstat 'D:\a\mill\mill\out\integration\feature\launcher-old-versions\fork\test.dest\mill.integration.LauncherVersionTests_0_10\sandbox\run-1\out\mill-worker-uyUCkqx6lYTWawU0H+fOCWvQ\u8=-1\mill-093bdc52daae5837bacc1b1b565ee261-io'
https://github.com/com-lihaoyi/mill/actions/runs/12565326528/job/35029611094

@lihaoyi lihaoyi marked this pull request as ready for review January 6, 2025 01:04
@lihaoyi lihaoyi merged commit 12c336e into com-lihaoyi:main Jan 6, 2025
26 checks passed
@lefou lefou added this to the 0.12.6 milestone Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants