Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part of #3928 [Web Examples] Add First Class Python Support #4107

Merged
merged 25 commits into from
Dec 23, 2024
Merged

Part of #3928 [Web Examples] Add First Class Python Support #4107

merged 25 commits into from
Dec 23, 2024

Conversation

himanshumahajan138
Copy link
Contributor

@himanshumahajan138 himanshumahajan138 commented Dec 11, 2024 •
edited
Loading

Pull Request

Adds First Class Python Support [Web Examples]
Part of #3928

Description

Web Examples for Python 1-hello-flask, 2-todo-flask, 3-hello-django, 4-todo-django Examples

Related Issues

Checklist

  • 1-hello-flask
  • 2-todo-flask
  • 3-hello-django
  • 4-todo-django
  • Updated Documentation

Status

Require Review!!!

@himanshumahajan138 himanshumahajan138 marked this pull request as ready for review December 12, 2024 19:54
@himanshumahajan138
Copy link
Contributor Author

@jodersky and @lihaoyi Please Review the code once...

Key Points:

  • Migrations automation(confused) Django Todo App
  • Structure of Django Code is maintained as per official structure
  • documentations will be updated after code acceptance
  • Code is Fully tested and require Reviews about structure and additional features

@himanshumahajan138 himanshumahajan138 changed the title [WIP] Part of #3928 [Web Examples] Add First Class Python Support Part of #3928 [Web Examples] Add First Class Python Support Dec 13, 2024
@himanshumahajan138
Copy link
Contributor Author

anyone up there please review...

@jodersky
Copy link
Member

I saw your request and will review it

@himanshumahajan138
Copy link
Contributor Author

himanshumahajan138 commented Dec 16, 2024 •
edited
Loading

@jodersky sir i think you are busy so now i am working on Docs and let's review after that finally ✨

jodersky
jodersky reviewed Dec 16, 2024
View reviewed changes
Copy link
Member

@jodersky jodersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a first glance this looks great, @himanshumahajan138! Could you please use python's style guide in all examples however? In particular method names in python should not be camelCase, but snake_case

example/pythonlib/web/1-hello-flask/foo/test/src/test.py Show resolved Hide resolved
@himanshumahajan138
Copy link
Contributor Author

himanshumahajan138 commented Dec 16, 2024 •
edited
Loading

@jodersky Sir, Let's Finalize this ✨

@himanshumahajan138
Copy link
Contributor Author

himanshumahajan138 commented Dec 19, 2024 •
edited
Loading

@lihaoyi sir i think @jodersky Sir is Busy but no worry, code is already satisfied and checked by him in first review and now only docs review is pending so i think whenever you are less busy then after reviewing we can merge this PR
Hope you Understand!

@jodersky
Copy link
Member

jodersky commented Dec 19, 2024 via email

@himanshumahajan138
Copy link
Contributor Author

hey, I'll go over it again today

That's great to hear from your side ✨

jodersky
jodersky approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@jodersky jodersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I'm not knowledgeable with Django, but what I see makes sense.

Thanks for waiting so long for the review

example/pythonlib/web/2-todo-flask/build.mill Outdated Show resolved Hide resolved
@himanshumahajan138
Copy link
Contributor Author

@lihaoyi Sir is this a todo 😅

image

to be honest last time when i created kotlin todo springboot example i haven't tested it...
it's not looking like an todo 😂

we have to make same like this ok then working...

@lihaoyi
Copy link
Member

lihaoyi commented Dec 20, 2024

yes that is what a todomvc example looks like. If you haven't googled it you should

@himanshumahajan138
Copy link
Contributor Author

yes that is what a todomvc example looks like. If you haven't googled it you should

sorry for my argument...

Working on this 🤞

@himanshumahajan138
Copy link
Contributor Author

himanshumahajan138 commented Dec 21, 2024 •
edited
Loading

@lihaoyi Sir we dont have to use db coz as i have seen in the 1-todo-webapp it's done using a class structure

so i am also following the available ethics...

if you want to add db then please tell me asap...

@himanshumahajan138
Copy link
Contributor Author

@lihaoyi Sir when less busy, could you please review the flask todo example i have followed almost the 1-todo-webapp format and i think this is perfect as per requirements

after review if satisfied with the code then i will update the django todo example

Hope you Understand...

@himanshumahajan138
Copy link
Contributor Author

Here are some Previews, i think now its perfect ✨

image
image
image
image
image
image

@lihaoyi
Copy link
Member

lihaoyi commented Dec 21, 2024

Seems the tests are failing

@himanshumahajan138
Copy link
Contributor Author

himanshumahajan138 commented Dec 22, 2024 •
edited
Loading

Seems the tests are failing

Sorry for this mistake actually the port in the app should be 5001 but i am running that on 5000 and checking for curl on 5001

Silly mistake sorry for such act 😞

@himanshumahajan138
Copy link
Contributor Author

@lihaoyi It's Done!!!

Both Flask and Django TodoMVC Examples Updated with Documentation Updation...

Let's Finalize this ☺️

@lihaoyi
Copy link
Member

lihaoyi commented Dec 23, 2024

Thanks @himanshumahajan138 , I think it looks great. Left some last comments then we can merge it

@himanshumahajan138
Copy link
Contributor Author

@lihaoyi sir can i use my name and point this to my github(may be you missed this )
IMG_20241223_075408

@lihaoyi
Copy link
Member

lihaoyi commented Dec 23, 2024

@himanshumahajan138 i saw that, i mean we should also add a link in the documentstion to the todomvc.com website, in addition to the links on the app itself

@himanshumahajan138
Copy link
Contributor Author

I don't know why whole Mill CI's Tests are fond of Failing in My PR they it feels like they are revenging on me 😂

Jokes Apart...

@lihaoyi Sir It's Done Let's Merge it

@himanshumahajan138
Copy link
Contributor Author

@lihaoyi Sir its passed 🎊

@lihaoyi lihaoyi merged commit d361ace into com-lihaoyi:main Dec 23, 2024
26 checks passed
@lihaoyi
Copy link
Member

lihaoyi commented Dec 23, 2024

Thanks @himanshumahajan138 , I'll close out the bounty and send you the receipt

@himanshumahajan138
Copy link
Contributor Author

@jodersky and @lihaoyi thanks for your guide and support ✨

@lefou lefou added this to the 0.12.5 milestone Dec 23, 2024
@himanshumahajan138 himanshumahajan138 deleted the issue-3928 branch December 24, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lihaoyi lihaoyi lihaoyi left review comments

@jodersky jodersky jodersky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12.5
Development

Successfully merging this pull request may close these issues.
4 participants
@himanshumahajan138 @jodersky @lihaoyi @lefou