Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move scope-related tasks together in JavaModule #4076

Merged

Conversation

alexarchambault
Copy link
Collaborator

@alexarchambault alexarchambault commented Dec 5, 2024

With the main task first, the compile-only one second, and the runtime one third

This makes it easier to change these methods, add related ones, etc.

This is already part of #4068. Opening the PR here to make it easier to review the changes here, and those of #4068 if the one here gets merged

With the main task first, the compile-only one second, and the runtime one third
@lihaoyi lihaoyi merged commit 30deaa5 into com-lihaoyi:main Dec 6, 2024
27 checks passed
@lefou lefou added this to the 0.12.4 milestone Dec 6, 2024
jodersky pushed a commit to jodersky/mill that referenced this pull request Jan 14, 2025
With the main task first, the compile-only one second, and the runtime
one third

This makes it easier to change these methods, add related ones, etc.

This is already part of com-lihaoyi#4068.
Opening the PR here to make it easier to review the changes here, and
those of com-lihaoyi#4068 if the one here
gets merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants