More fixes for prompt logger #4075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jodersky
pushed a commit
to jodersky/mill
that referenced
this pull request
Jan 14, 2025
Fixes com-lihaoyi#4074 We shouldn't sleep for `nonInteractivePromptUpdateIntervalMillis` every time `readTerminalDims` fails, because that means if there's a transient failure it doesn't check again for 60s during which there is no prompt shown Instead, we always check after `promptUpdateIntervalMillis` seconds, and but only refresh the prompt if `now - lastUpdate > nonInteractivePromptUpdateIntervalMillis` Also we make sure we call `writeTerminalDims` at least once before we start the Mill background process, rather than relying on the background thread to reach that code path in time Either of these fixes alone should solve the issue, but might as well do both
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4074
We shouldn't sleep for
nonInteractivePromptUpdateIntervalMillisevery timereadTerminalDimsfails, because that means if there's a transient failure it doesn't check again for 60s during which there is no prompt shownInstead, we always check after
promptUpdateIntervalMillisseconds, and but only refresh the prompt ifnow - lastUpdate > nonInteractivePromptUpdateIntervalMillisAlso we make sure we call
writeTerminalDimsat least once before we start the Mill background process, rather than relying on the background thread to reach that code path in timeEither of these fixes alone should solve the issue, but might as well do both