Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonlib: add linting with ruff #4072

Merged
merged 17 commits into from
Jan 31, 2025
Merged

pythonlib: add linting with ruff #4072

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ef068e1
wip
jodersky Dec 4, 2024
36b8f8d
todo
jodersky Dec 4, 2024
9492d2e
wip
jodersky Dec 4, 2024
2ff522d
wip
jodersky Dec 10, 2024
2b13e81
wip
jodersky Jan 4, 2025
61c8998
wip
jodersky Jan 24, 2025
aaa7c29
.
jodersky Jan 24, 2025
994c85c
.
jodersky Jan 24, 2025
2981af4
shellable => string
jodersky Jan 25, 2025
91b47d5
add global format and check tasks
jodersky Jan 26, 2025
4e5f257
.
jodersky Jan 26, 2025
c073036
wip
jodersky Jan 31, 2025
0f3d477
remove coverage wip
jodersky Jan 31, 2025
5f44c29
fix typo after rebase
jodersky Jan 31, 2025
e2d3dc5
[autofix.ci] apply automated fixes
autofix-ci[bot] Jan 31, 2025
09a21a6
Update linting.adoc
lihaoyi Jan 31, 2025
7c557fe
fix python unit tests
lihaoyi Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[autofix.ci] apply automated fixes
  • Loading branch information
@autofix-ci
autofix-ci[bot] authored Jan 31, 2025
commit e2d3dc5d52823bd4fc31c63bca653edcfe4b702e
3 changes: 1 addition & 2 deletions example/pythonlib/linting/2-ruff-check/build.mill
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
package build
import mill._, pythonlib._

object `package` extends RootModule with PythonModule with RuffModule {
}
object `package` extends RootModule with PythonModule with RuffModule {}

/** See Also: src/main.py */

Expand Down
10 changes: 5 additions & 5 deletions pythonlib/src/mill/pythonlib/RuffModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ trait RuffModule extends PythonModule {
*/
def ruffOptions: T[Seq[String]] = Task { Seq.empty[String] }

protected def configArgs: Task[Seq[String]] = Task.Anon {
protected def configArgs: Task[Seq[String]] = Task.Anon {
val cfg = ruffConfigFile()
if (os.exists(cfg.path)) Seq("--config", cfg.path.toString) else Seq.empty[String]
}
Expand Down Expand Up @@ -84,8 +84,8 @@ object RuffModule extends ExternalModule with RuffModule with TaskModule {
override def defaultCommandName(): String = "formatAll"

def formatAll(
sources: Tasks[Seq[PathRef]] = Tasks.resolveMainDefault("__.sources"),
@mainargs.arg(positional = true) ruffArgs: Args
sources: Tasks[Seq[PathRef]] = Tasks.resolveMainDefault("__.sources"),
@mainargs.arg(positional = true) ruffArgs: Args
): Command[Unit] = Task.Command {
runner().run(
// format: off
Expand All @@ -103,8 +103,8 @@ object RuffModule extends ExternalModule with RuffModule with TaskModule {
}

def checkAll(
sources: Tasks[Seq[PathRef]] = Tasks.resolveMainDefault("__.sources"),
@mainargs.arg(positional = true) ruffArgs: Args
sources: Tasks[Seq[PathRef]] = Tasks.resolveMainDefault("__.sources"),
@mainargs.arg(positional = true) ruffArgs: Args
): Command[Unit] = Task.Command {
runner().run(
// format: off
Expand Down
Loading