backtick when path segment is scala keyword #3865
Conversation
| package build.`import` | ||
| import mill._, scalalib._ | ||
|
|
||
| object `package` extends RootModule with ScalaModule { |
There was a problem hiding this comment.
Let's not make this a ScalaModule, since we don't care about the scala side at all. Instead, we can just add a trivial def task = Task { 123 }
Furthermore, let's exercise a few more Scala keywords, with this/package.mill, for/package.mill, if/package.mill, just to make sure it works for more than just the single import keyword
There was a problem hiding this comment.
I added few more case. One interesting point is that `package` will fail but I assume it's not due to backtick as mill complain this way:
[2758] [build.mill-57] [error] /home/Chikei/repos/mill/out/integration/feature/keyword-module/local/test.dest/sandbox/run-1/out/mill-build/generateScriptSources.dest/build_/build.mill:21:21: lazy value millDiscover overrides nothing
[2758] [build.mill-57] [error] override lazy val millDiscover: _root_.mill.define.Discover = _root_.mill.define.Discover[this.type]
[2758] [build.mill-57] [error] ^
[2758] [build.mill-57] [error] one error found
So I just removed it from cases for now.
| @@ -33,7 +34,8 @@ case class FileImportGraph( | |||
| object FileImportGraph { | |||
| def backtickWrap(s: String): String = s match { | |||
| case s"`$v`" => s | |||
| case _ => if (encode(s) == s) s else "`" + s + "`" | |||
| case _ => if (encode(s) == s) runtime.universe.asInstanceOf[runtime.JavaUniverse].quotedName(s) | |||
There was a problem hiding this comment.
Rather than relying on runtime.JavaUniverse, let's instead port over the user-land implementation from Ammonite. That will make it a smoother upgrade to Scala 3 where runtime.JavaUniverse might not exist
There was a problem hiding this comment.
So I just grab the alphabet keywords from ammonite since NameTransformer should handle the other case and that exists in scala 3 stdlib
to allow submodule use scala keyword as name, fix #3863
I am not sure this is the way we want to match scala keyword though