ScalaPB Plugin: Add option scala3_sources #3258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lefou
reviewed
Jul 25, 2024
|
I've added a simple test, but I don't know if this is enough. If not, can you please give me a hint on how to improve it? |
lefou
reviewed
Aug 1, 2024
| @@ -182,6 +188,11 @@ object TutorialTests extends TestSuite { | |||
| } | |||
| } | |||
|
|
|||
| "calledWithScala3Sources" - workspaceTest(TutorialWithScala3Soures) { eval => | |||
| val result = eval.apply(Tutorial.core.compileScalaPB) | |||
| assert(result.isRight) | |||
There was a problem hiding this comment.
@b-eyselein Is there something unique to the scala3_sources option in the generated file(s)? you could assert some specific file content.
There was a problem hiding this comment.
It mainly uses ? instead of _for unknown types which generates a bunch of compiler warnings...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the title says, this option allows users of the
scalapb-Plugin to submit the optionscala3_sourcestoscalapbdirectly.