Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ScalaModule.scalacHelp command #2921

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Add ScalaModule.scalacHelp command #2921

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b342884
Add `ScalaModule.scalacHelp` command
lefou Dec 13, 2023
7d778e6
Added support for Scala 3.x and older 2.x versions
lefou Dec 13, 2023
6ee988e
scalafmt
lefou Dec 13, 2023
f0f9624
Close classloader after use
lefou Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
scalafmt
  • Loading branch information
@lefou
lefou committed Dec 13, 2023
commit 6ee988e2f6e9995cd388c95f2ca5db29f9f54831
4 changes: 2 additions & 2 deletions scalalib/src/mill/scalalib/ScalaModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,8 +119,8 @@ trait ScalaModule extends JavaModule with TestModule.ScalaModuleBase { outer =>
val fail = Result.Failure("The compiler exited with errors (exit code 1)")

{
case true | java.lang.Boolean.TRUE => if(trueIsSuccess) ok else fail
case false | java.lang.Boolean.FALSE => if(trueIsSuccess) fail else ok
case true | java.lang.Boolean.TRUE => if (trueIsSuccess) ok else fail
case false | java.lang.Boolean.FALSE => if (trueIsSuccess) fail else ok
case null if sv.startsWith("2.") =>
// Scala 2.11 and earlier return `Unit` and require use to use the result value,
// which we don't want to implement for just a simple help output of an very old compiler
Expand Down