-
-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move BuildInfo from sources into resources, defer use of resources during compilation #2425
Merged
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
504d6ff
.
lihaoyi 1075d7e
build.sc compiles
lihaoyi 482b52f
move to resource based buildinfo
lihaoyi 18a54a4
.
lihaoyi c9382e5
cleanup
lihaoyi 9eef9c3
fix
lihaoyi 028c779
.
lihaoyi cddc254
transitiveCompileClasspath should include compile.classes
lihaoyi 0dc7664
wip replacing contribu/buildinfo with new implementation
lihaoyi 80b8d0b
contrib.buildinfo.test passes
lihaoyi 1a5bb75
fix build.sc
lihaoyi ac0e98e
.
lihaoyi f6e96b0
.
lihaoyi 5050886
.
lihaoyi f490919
update patch bootstrap
lihaoyi 196c320
add mill-contrib-buildinfo import to patch
lihaoyi e2625ce
scaladoc
lihaoyi e28d97f
fixcompile
lihaoyi fe6aef7
fix-compile
lihaoyi a622dca
.
lihaoyi 6600186
fixbsp
lihaoyi f351a10
add import to patch
lihaoyi 2c2590d
.
lihaoyi a5fabc3
fixpatch
lihaoyi a5f9e54
BuildInfo.Value
lihaoyi 147942e
update patch
lihaoyi 8af9b5d
fixbuild
lihaoyi 6590af0
.
lihaoyi 1455fcd
rename to BuildInfo.buildinfo.properties
lihaoyi d2ebf93
use relative getResourceAsStream
lihaoyi 818f7fc
.
lihaoyi 6aa9984
update build.sc buildinfo
lihaoyi e229fc9
update
lihaoyi 235fc7f
remove-println
lihaoyi d50c0ed
fix-patch
lihaoyi 1ae58e4
.
lihaoyi f725a38
debug
lihaoyi 8ea492f
.
lihaoyi 8d7f669
add publishLocal to make test-mill-dev pass
lihaoyi a6e2084
bump timeout for flaky test
lihaoyi f36c0b8
scalafmt
lihaoyi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
scaladoc
- Loading branch information
commit e2625ce6f57f3224cc9141e147aeff7629f95041
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file generation should be a dedicated target. This helps when someone needs to override the
resources
target but wants to keep some overridden functionality, or if the file is needed elsewhere.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done