Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 8 to build release artifacts #1421

Merged
merged 1 commit into from
Jul 25, 2021

Conversation

lefou
Copy link
Member

@lefou lefou commented Jul 23, 2021

No description provided.

In preparation to enable MiMa checks, we don't want to sneak some newer API in.
@ice1000
Copy link

ice1000 commented Jul 25, 2021

What's the rationale?

@lefou
Copy link
Member Author

lefou commented Jul 25, 2021

Before this PR, we published with Java 9. Although we explicitly select the target as Java 8, some binary incompatibilities sneaked in all of our current releases. So, I think it's safer to just use Java 8 for compiling the release versions.

See the output of this experimental integration of MiMa in the mill build:

09:59:20 ⌁ lefou:~/work/opensource/mill mima+* 130 ± mill -j 0 main.__.mimaReportBinaryIssues
Using experimental parallel evaluator with 16 threads
[#07] [281/306] main.core.compile 
[#11] Scanning 79 classfiles for binary compatibility in /home/lefou/work/opensource/mill/out/main/api/compile/dest/classes ...
[#03] [282/306] scalalib.api.localClasspath 
[#11]  * static method transferTo(java.io.OutputStream)Long in class mill.api.DummyInputStream does not have a correspondent in current version
   filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("mill.api.DummyInputStream.transferTo")
[#11]  * static method readNBytes(Array[Byte],Int,Int)Int in class mill.api.DummyInputStream does not have a correspondent in current version
   filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("mill.api.DummyInputStream.readNBytes")
[#11]  * static method readAllBytes()Array[Byte] in class mill.api.DummyInputStream does not have a correspondent in current version
   filter with: ProblemFilters.exclude[DirectMissingMethodProblem]("mill.api.DummyInputStream.readAllBytes")

You can see that comparing the HEAD of 0.9.x branch with the 0.9.9 tag, some methods only defined in Java 9 sneak into our API. This happens when I run (and compile) mill with Java 8.

@ice1000
Copy link

ice1000 commented Jul 25, 2021

Thanks for the explanation!

@lefou lefou merged commit 51620e7 into com-lihaoyi:main Jul 25, 2021
@lefou lefou deleted the release-with-java-8 branch July 25, 2021 13:18
@lefou lefou added this to the 0.10.0 milestone Jul 25, 2021
@lolgab
Copy link
Member

lolgab commented Jul 28, 2021

Glad that the mill-mima plugin is already creating some value 😍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants