Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mill.scalalib.checkstyle.CheckstyleModuleTest always fails #4534

Closed
lefou opened this issue Feb 12, 2025 · 1 comment · Fixed by #4535
Closed

mill.scalalib.checkstyle.CheckstyleModuleTest always fails #4534

lefou opened this issue Feb 12, 2025 · 1 comment · Fixed by #4535
Milestone

Comments

@lefou
Copy link
Member

lefou commented Feb 12, 2025

Reproduce:

> mill -j1 scalalib.test.testOnly mill.javalib.checkstyle.CheckstyleModuleTest
...
[1444] mill.testkit.UnitTester: running checkstyle ...
[1444] Checkstyle endet mit 2 Fehlern.
[1444] mill.testkit.UnitTester: checkstyle output report at /home/lefou/work/opensource/mill/out/scalalib/test/testOnly.dest/sandbox/out/mill-test-base-module/16381572422961682342/out/checkstyleOutput.dest/checkstyle-output.xml
[1444] mill.testkit.UnitTester: checkstyle found 2 violation(s)
[1444] X mill.javalib.checkstyle.CheckstyleModuleTest.arguments.sources 1042ms 
[1444]   utest.AssertionError: #1: testJava(
[1444]               resources / "non-compatible",
[1444]               violations = violations.take(2),
[1444]               sources = Seq("src/blocks")
[1444]             )
[1444]   resources: os.Path = /home/lefou/work/opensource/mill/scalalib/test/resources/checkstyle
[1444]   violations: Seq[String] = List(Array should contain trailing comma, Array should contain trailing comma, Empty statement, Empty statement)
[1444]     utest.asserts.Asserts$.assertImpl(Asserts.scala:30)
[1444]     mill.javalib.checkstyle.CheckstyleModuleTest$.tests$$anonfun$1$$anonfun$1$$anonfun$3(CheckstyleModuleTest.scala:12)
...
[1444] mill.testkit.UnitTester: running checkstyle ...
[1444] Checkstyle endet mit 4 Fehlern.
[1444] mill.testkit.UnitTester: checkstyle output report at /home/lefou/work/opensource/mill/out/scalalib/test/testOnly.dest/sandbox/out/mill-test-base-module/8340530497038255299/out/checkstyleOutput.dest/checkstyle-output.plain
[1444] mill.testkit.UnitTester: checkstyle found 4 violation(s)
[1444] X mill.javalib.checkstyle.CheckstyleModuleTest.settings.format 976ms 
[1444]   utest.AssertionError: #1: testJava(resources / "non-compatible", "plain", violations = violations)
[1444]   resources: os.Path = /home/lefou/work/opensource/mill/scalalib/test/resources/checkstyle
[1444]   violations: Seq[String] = List(Array should contain trailing comma, Array should contain trailing comma, Empty statement, Empty statement)
[1444]     utest.asserts.Asserts$.assertImpl(Asserts.scala:30)
[1444]     mill.javalib.checkstyle.CheckstyleModuleTest$.tests$$anonfun$1$$anonfun$2$$anonfun$1(CheckstyleModuleTest.scala:12)
...
[1444] mill.testkit.UnitTester: running checkstyle ...
[1444] mill.testkit.UnitTester: checkstyle output report at /home/lefou/work/opensource/mill/out/scalalib/test/testOnly.dest/sandbox/out/mill-test-base-module/13753980815456980494/out/checkstyleOutput.dest/checkstyle-output.plain
[1444] mill.testkit.UnitTester: checkstyle found 1 violation(s)
[1444] X mill.javalib.checkstyle.CheckstyleModuleTest.limitations.incompatible version generates report with unexpected violation 392ms 
[1444]   utest.AssertionError: #1: testJava(
[1444]               resources / "compatible-java",
[1444]               "plain",
[1444]               "6.2",
[1444]               violations = Seq("File not found")
[1444]             )
[1444]   resources: os.Path = /home/lefou/work/opensource/mill/scalalib/test/resources/checkstyle
[1444]     utest.asserts.Asserts$.assertImpl(Asserts.scala:30)
[1444]     mill.javalib.checkstyle.CheckstyleModuleTest$.tests$$anonfun$1$$anonfun$3$$anonfun$1(CheckstyleModuleTest.scala:12)
...
1 tasks failed
scalalib.test.testOnly 3 tests failed: 
  mill.javalib.checkstyle.CheckstyleModuleTest mill.javalib.checkstyle.CheckstyleModuleTest.arguments.sources
  mill.javalib.checkstyle.CheckstyleModuleTest mill.javalib.checkstyle.CheckstyleModuleTest.settings.format
  mill.javalib.checkstyle.CheckstyleModuleTest mill.javalib.checkstyle.CheckstyleModuleTest.limitations.incompatible version generates report with unexpected violation
@lefou
Copy link
Member Author

lefou commented Feb 12, 2025

On my local machine, this seems to be a locale issue. But it also failed on CI.

lefou added a commit to lefou/mill that referenced this issue Feb 12, 2025
Should fix locale specific isues in checkstyle tests

Fix com-lihaoyi#4534
@lefou lefou closed this as completed in 654a644 Feb 12, 2025
@lefou lefou added this to the 0.13.0 milestone Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant