Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BSP: MatchError when a TestModule is used in isolation #3110

Closed
lefou opened this issue Apr 8, 2024 · 2 comments · Fixed by #3111
Closed

BSP: MatchError when a TestModule is used in isolation #3110

lefou opened this issue Apr 8, 2024 · 2 comments · Fixed by #3111
Labels
bug The issue represents an bug
Milestone
0.11.8

Comments

@lefou
Copy link
Member

lefou commented Apr 8, 2024 •
edited
Loading

So I tried defining additional test without an real language module, this line in mill will throw a MatchError as the additional test module does not inherent JavaModule.

Originally posted by @chikei in #3064 (comment)
@lefou lefou mentioned this issue Apr 8, 2024
Merged
@lefou lefou added the bug The issue represents an bug label Apr 8, 2024
@lefou
Copy link
Member Author

lefou commented Apr 9, 2024

In PR #3111 I think I fixed the MatchError, but haven't tested it, due to a missing test suite and spare time. @chikei If you want to give it a try, I'm happy to get your feedback.

@chikei
Copy link
Contributor

chikei commented Apr 10, 2024

Just tried IJ bsp import, I think the PR fixed the issue.

@lefou lefou mentioned this issue Apr 23, 2024
Merged
lefou added a commit that referenced this issue Apr 23, 2024
@lefou
Improve internal BSP API and docs, fix a match error condition (#3111)
4c7e5d8 
Add some docs and todos.
Avoid MatchError.
Consider compileModuleDeps as dependencies.

Fix: #3110
@lefou lefou added this to the 0.11.8 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug The issue represents an bug
Projects
None yet
Milestone
0.11.8
Development

Successfully merging a pull request may close this issue.

Improve internal BSP API and docs, fix a match error condition com-lihaoyi/mill
2 participants
@chikei @lefou