Skip to content

Commit

Permalink
Prefer repositoriesTask to hard-coded repositories in scalapblib (#3529)
Browse files Browse the repository at this point in the history
Just stumbled upon that while looking at how default repositories were
handled in Mill (fine overall, but here 😅). I'm not sure how one would
prefer hard-coded repositories over the ones from `repositoriesTask`
(which should correspond to the hard-coded ones most of the time, except
when users favor another Maven mirror).

Pull request: #3529
  • Loading branch information
alexarchambault authored Sep 12, 2024
1 parent 5588448 commit b5e5563
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package mill
package contrib.scalapblib

import coursier.MavenRepository
import coursier.core.Version
import mill.api.{IO, Loose, PathRef}
import mill.scalalib.Lib.resolveDependencies
Expand Down Expand Up @@ -75,10 +74,7 @@ trait ScalaPBModule extends ScalaModule {

def scalaPBClasspath: T[Loose.Agg[PathRef]] = T {
resolveDependencies(
Seq(
coursier.LocalRepositories.ivy2Local,
MavenRepository("https://repo1.maven.org/maven2")
),
repositoriesTask(),
Seq(ivy"com.thesamet.scalapb::scalapbc:${scalaPBVersion()}")
.map(Lib.depToBoundDep(_, "2.13.1"))
)
Expand Down

0 comments on commit b5e5563

Please sign in to comment.