Support Java 20 (#2501)

Ignore the `UnsupportedOperationException` of `Thread.stop`. This is a quick fix to de-block users from using Java 20. Added a bootstrap CI run using Java 20. Pull request: #2501
com-lihaoyi · May 5, 2023 · 514e014 · 514e014
1 parent bd502f7
commit 514e014
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/.github/workflows/actions.yml b/.github/workflows/actions.yml
@@ -68,6 +68,10 @@ jobs:
           - java-version: 17
             buildcmd: ./mill -i docs.githubPages
 
+          # Have one job on latest JVM
+          - java-version: 20
+            buildcmd: ci/test-mill-bootstrap.sh
+
     uses: ./.github/workflows/run-mill-action.yml
     with:
       os: ubuntu-latest

diff --git a/runner/src/mill/runner/MillServerMain.scala b/runner/src/mill/runner/MillServerMain.scala
@@ -204,6 +204,8 @@ class Server[T](
     Thread.sleep(5)
     try t.stop()
     catch {
+      case e: UnsupportedOperationException =>
+      // nothing we can do about, removed in Java 20
       case e: java.lang.Error if e.getMessage.contains("Cleaner terminated abnormally") =>
       // ignore this error and do nothing; seems benign
     }