fix: stan errors

[taka-oyama]

Changed to use contracts where applicable to fix stan errors.

Illuminate\Database\Query\Expression -> Illuminate\Contracts\Database\Query\Expression

Summary by CodeRabbit

• Refactor
  • Updated import statements for Expression class across multiple files
  • Modified method signatures to improve type safety and clarity
  • Refined type handling for expressions in column definitions and database queries

[coderabbitai]

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 PHPStan (2.0.3)

/bin/bash: line 1: /vendor/bin/phpstan: No such file or directory

Walkthrough

The pull request introduces changes to several files in the project, focusing on updating the import and usage of the Expression class. The modifications primarily involve switching the Expression import from a specific implementation to a more general contract interface across Connection.php, ColumnDefinition.php, and Grammar.php. These changes aim to improve type handling and consistency in how expressions are used within database-related classes.

Changes

File	Change Summary
src/Connection.php	- Updated Expression import from Illuminate\Database\Query to Illuminate\Contracts\Database\Query - Added explicit QueryBuilder return type to table() and query() methods
src/Schema/ColumnDefinition.php	- Changed Expression import from Illuminate\Database\Query\Expression to Illuminate\Contracts\Database\Query\Expression
src/Schema/Grammar.php	- Modified modifyGeneratedAs method to use ExpressionContract instead of Expression - Updated formatDefaultValue method to check for ExpressionContract

Possibly related PRs

• feat: IDENTITY column support #243: Changes related to modifications in the Grammar class involving expressions and identity columns

Suggested labels

enhancement

Suggested reviewers

• halnique

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e53489 and da6e7e0.

📒 Files selected for processing (3)

• src/Connection.php (1 hunks)
• src/Schema/ColumnDefinition.php (1 hunks)
• src/Schema/Grammar.php (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Run-PHPUnit

🔇 Additional comments (3)

src/Schema/ColumnDefinition.php (1)

23-23: LGTM! Good use of interface over implementation.

The change to import Expression from Illuminate\Contracts\Database\Query\Expression instead of Illuminate\Database\Query\Expression follows the dependency inversion principle by depending on abstractions rather than concrete implementations.

src/Connection.php (1)

40-40: LGTM! Good use of interface over implementation.

The change to import Expression from Illuminate\Contracts\Database\Query\Expression instead of Illuminate\Database\Query\Expression follows the dependency inversion principle by depending on abstractions rather than concrete implementations.

src/Schema/Grammar.php (1)

861-861: LGTM! Good use of interface over implementation.

The change to check for ExpressionContract instead of Expression follows the dependency inversion principle by depending on abstractions rather than concrete implementations.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[taka-oyama]

Thank you for reviewing