Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip query string before testing which urls to strip cookies on #43

Merged
merged 2 commits into from
Sep 8, 2017

Conversation

instification
Copy link
Member

This is a PR to resolve issue #42

Instead of comparing the url to req.url compare it to a new variable set on req.http which has the query string removed.

Copy link
Member

@jensens jensens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just for some reason at the coverage report on Travis is hanging, I restarted the job.

@instification
Copy link
Member Author

thanks for looking at that @jensens

what is the procedure now you have approved it? Do I just merge the PR or should I wait for a package maintainer to do it?

I've submitted another pr #44 to try and address the issue with travis

@coveralls
Copy link

coveralls commented Sep 8, 2017

Coverage Status

Coverage remained the same at 96.269% when pulling d43372f on instification/theme-editor-bugfix into f1e1b20 on master.

@jensens jensens merged commit 2a9b138 into master Sep 8, 2017
@jensens jensens deleted the instification/theme-editor-bugfix branch September 8, 2017 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants