-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Python 2.6 #246
Conversation
Looks like I introduced some Travis failures. I'll need to investigate those before this is merge ready. |
All tests now pass. |
Here's the pip installs for icalendar from PyPI for the last month:
You could also consider dropping 3.3, which went EOL last month and like 2.6 also has low numbers. And here's pip installs across PyPI showing 2.6 is now more like ~1% than ~2%.
|
I'm happy to also drop support for Python 3.3 if it is agreeable with the project maintainers. @untitaker what do you think? |
I'm specifically waiting for the feedback of the people I mentioned above. I
don't have any objections myself, but want to wait for their response.
…On Fri, Oct 27, 2017 at 01:20:07PM +0000, Jon Dufresne wrote:
I'm happy to also drop support for Python 3.3 if it is agreeable with the project maintainers. @untitaker what do you think?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#246 (comment)
|
@untitaker @jdufresne @hugovk Doing would normally include a major version increase - which implies adapting the semantic versioning scheme. But that's another discussion. |
I would humbly like to suggest icalendar drop support for Python 2.6. The last release of Python 2.6 was 2013-10-29. It is no longer receiving security or bug fixes. https://www.python.org/dev/peps/pep-0361/ The pip project itself has decided to drop support for 2.6. At the beginning of the year, their numbers estimated that Python 2.6 accounts for ~2% of their downloads. pypa/pip#4343 For projects that still use Python 2.6, they can continue to pip install an older version. I've tried my best to remove as much 2.6 specific code as I can, including the 'Programming Language :: Python :: 2.6' trove classifier from setup.py. I've also removed Travis CI testing, which should result in slightly faster testing and fewer wasted resources. Changed: * Update documented Python support and trove classifiers * Update Travis test matrix and tox test matrix * Use set literals (and more literals in general) * Use dict comprehension * Remove dependencies on ordereddict and unittest2 * Remove u string prefix, use more modern unicode literals instead
Thanks. Done! I've removed 3.3 support in the latest revision. All additional feedback is welcome. |
LGTM, also a good amound of nice code cleanups. @jdufresne great, thanks! |
Also, I'll bump the version to 4.0 I guess. |
May want to consider quoting the versions in |
Interesting. Thanks for that link. I wasn't aware of that gotcha. |
Good to know, at least we're some time away from Python 3.10 :) |
I would humbly like to suggest icalendar drop support for Python 2.6.
The last release of Python 2.6 was 2013-10-29, almost 4 years ago. It is no longer receiving security or bug fixes.
https://www.python.org/dev/peps/pep-0361/
The pip project itself has recently dropped support for 2.6. At the beginning of the year, their numbers estimated that Python 2.6 accounts for ~2% of their downloads.
pypa/pip#4343
For projects that still use Python 2.6, they can continue to pip install an older version.
I've tried my best to remove as much 2.6 specific code as I can, including the
'Programming Language :: Python :: 2.6'
trove classifier from setup.py. I've also removed Travis CI testing, which should resultin slightly faster testing and fewer wasted resources.
Changed:
u
string prefix, use more modern unicode literals instead