-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ISO formatted strings being allowed as date inputs #34
Merged
JeffersonBledsoe
merged 8 commits into
main
from
separate-friendly-email-internal-dates
Sep 17, 2024
Merged
Added ISO formatted strings being allowed as date inputs #34
JeffersonBledsoe
merged 8 commits into
main
from
separate-friendly-email-internal-dates
Sep 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7991976848Details
💛 - Coveralls |
@JeffersonBledsoe now the tests are green here, but your changes don't seem to be covered by the tests |
mamico
approved these changes
Feb 21, 2024
mamico
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the start of using full ISO 8601 datetime strings for all submissions of dates and using the backend to friendly-format them in the sent emails.
A PR to volto-form-block needs to be made removing the formatting of dates client-side and sending them as ISO-compliant strings for this to be an effective PR.