Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ISO formatted strings being allowed as date inputs #34

Merged
merged 8 commits into from
Sep 17, 2024

Conversation

JeffersonBledsoe
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe commented Jul 20, 2023

This PR is the start of using full ISO 8601 datetime strings for all submissions of dates and using the backend to friendly-format them in the sent emails.
A PR to volto-form-block needs to be made removing the formatting of dates client-side and sending them as ISO-compliant strings for this to be an effective PR.

@JeffersonBledsoe
Copy link
Member Author

@cekk @pnicolli Any thoughts on this? We had a client comment on being able to use the CSV and XML data of submission in external system with full timezone strings, but still be able to nicely read the dates in any emails that are sent

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7991976848

Details

  • -1 of 11 (90.91%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.683%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/collective/volto/formsupport/restapi/services/submit_form/post.py 10 11 90.91%
Totals Coverage Status
Change from base Build 7919988301: 0.02%
Covered Lines: 678
Relevant Lines: 756

💛 - Coveralls

@mamico
Copy link
Contributor

mamico commented Feb 21, 2024

@JeffersonBledsoe now the tests are green here, but your changes don't seem to be covered by the tests
image

@mamico mamico self-requested a review February 21, 2024 17:57
@JeffersonBledsoe JeffersonBledsoe marked this pull request as ready for review September 16, 2024 12:52
Copy link
Contributor

@mamico mamico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JeffersonBledsoe JeffersonBledsoe changed the title Send dates as formatted strings Added ISO formatted strings being allowed as date inputs Sep 17, 2024
@JeffersonBledsoe JeffersonBledsoe merged commit b12e4cd into main Sep 17, 2024
7 checks passed
@JeffersonBledsoe JeffersonBledsoe deleted the separate-friendly-email-internal-dates branch September 17, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants