Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export and import content revisions #107

Merged
merged 18 commits into from
Apr 26, 2022
Merged

Conversation

pbauer
Copy link
Member

@pbauer pbauer commented Feb 4, 2022

@pbauer pbauer marked this pull request as draft February 12, 2022 09:48
Base automatically changed from workflow_history to main February 12, 2022 12:56
@pbauer pbauer force-pushed the exportimport_content_revisions branch from 0b7adbb to 73b9371 Compare February 12, 2022 13:06
@pbauer pbauer requested a review from mauritsvanrees April 23, 2022 06:46
@pbauer pbauer marked this pull request as ready for review April 24, 2022 15:28
@pbauer
Copy link
Member Author

pbauer commented Apr 24, 2022

I think this is ready.

@pbauer pbauer requested a review from fredvd April 24, 2022 15:28
Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and it works for me when exporting a few Dexterity items from Plone 4.3 into Plone 6.0. The history viewlet looks the same afterwards. So fine to merge.

Just two inline comments that could be addressed. But since it works, I approve.
Thanks!

@fredvd
Copy link
Member

fredvd commented Apr 26, 2022

Finally finished the ordeal of recording a screencast on my own. I'll quickly test this branch with the setup I used for recording my WPD talk.

@fredvd
Copy link
Member

fredvd commented Apr 26, 2022

I have 'end user' tested with a small Plone 4.3.20 site with around 90 content items of which 10 documents. The revisions are exported and imported, but when I look into the revision details, only the number of revisions match. Import into Plone 6.0a4 classic setup.

  • The date of all revisions is set to the date of the newest revision(live version).
  • Also If I try to compare revisions no changes at all displayed. When I do this in the Plone 4 site I do see changes in the main text being highlighted etc. etc.
  • the creation, initial revision and publish lines in the history have the correct author set. All subsequent revisions are ownd by the user under which I ran the import (admin).

@pbauer
Copy link
Member Author

pbauer commented Apr 26, 2022

Oh, yes, I totally forgot a very important detail! I guess you tested exporting Archetypes content on 4.3.x?
To serialize versions of AT content you need this fix in plone.restapi: plone/plone.restapi#1335). It is merged in the branch 7.x.x of plone.restapi (8.x.x no longer supports AT) and until a new releasae of 7.x is done you need a source checkout. Sorry.

@pbauer pbauer merged commit 8d7cb02 into main Apr 26, 2022
@pbauer pbauer deleted the exportimport_content_revisions branch February 3, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants