Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRYD-1608: Use coalesce to avoid null error #446

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Use coalesce on parties involved fields

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1608

Previously we updated the parties involved to aggregate all parties instead of a single. We forgot to update the query to coalesce against an empty array in order for the JS expression to work without needing additional null checks.

How should this be tested? Do these changes have associated tests?

  • Redeploy the report
  • Create a single Summary Documentation
  • Run the Notice of Intent to Repatriate report

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally

@mikejritter mikejritter changed the base branch from master to v8.1-branch January 7, 2025 21:32
@mikejritter mikejritter merged commit 51aa250 into collectionspace:v8.1-branch Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant