Consultation Report QA

[mikejritter]

What does this do?

• All - Use LocalDate for date formatting
• All - Adjust header height for text which was clipped
• Inventory - Include date with status when available
• Summary - Join related sites on collection objects
• Repatriation - Add field collection sites

Why are we doing this? (with JIRA link)
Jira:

• https://collectionspace.atlassian.net/browse/DRYD-1512
• https://collectionspace.atlassian.net/browse/DRYD-1513
• https://collectionspace.atlassian.net/browse/DRYD-1514

These come from the first round of QA testing. On dev the date fields were being display as ${day}-1 which is odd but we've changed to LocalDate in an attempt to resolve this. Note that they are stored in the db without a timezone and I'm not sure exactly where a tz is being implicitly added, but LocalDate does not have one so hopefully it will work as expected. If not we can handle the formatting in the query.

The Inventory Consultation report was missing the inventory date which should have been included with the inventory status when present.

The Summary Consultation report needed to pull archaeological sites from the related CollectionObject's field collection sites.

There were also some copy/pasted column names which I've updated for each report so that the column names are consistent with the record type.

How should this be tested? Do these changes have associated tests?

• Rebuild collectionspace
• Search for NAGPRA Inventories
  • Select some and run the Inventory Consultation report
• Search for Summary Documentations
  • Select some and run the Summary Documentation Consultation report
• Search for Repatriation Requests
  • Select some and run the Repatriation Request Consultation report

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally