NAGPRA Reports QA

[mikejritter]

What does this do?

• Notice of Inventory - Fix join for object counts
• Notice of Inventory - Fix join for acquisition date
• Notice of Inventory - Coalesce for better null handling
• Notice of Inventory - Switch to Javascript templating
• Notice of Inventory - Adjust spacing and increase header height
• Notice of Inventory - Add noData section when result set is empty
• Notice of Repatriation - Increase header height

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1335

These are the results from QA for the Notice of Inventory Completion report. It changes from groovy to javascript for templating in order to have an easier time combining fields which need to be formatted. In addition we now coalesce on all arrays/counts in order to provide empty/0 and make our lives a little easier when writing the text formatters. A noData section has been added as this report can be empty if no related objects exist.

I also missed updating the header height in Notice of Repatriation so I've added it here.

How should this be tested? Do these changes have associated tests?

• Rebuild CollectionSpace
• Navigate to a NAGPRA Inventory
• Run the Notice of Inventory Completion report and see the updates

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested locally