Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ObjectExit and Deaccession Term Lists #292

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

mikejritter
Copy link
Contributor

What does this do?

  • Add Deaccession Reason
  • Add Exit Reason
  • Add Exit Method

Why are we doing this? (with JIRA link)

These are new term lists which will be required for the new Deaccession and Object Exit procedures.

How should this be tested? Do these changes have associated tests?

  • Rebuild and start collectionspace
  • Query the vocabularies endpoint for the new vocabs, e.g.
curl -u [email protected]:Administrator "http://localhost:8180/cspace-services/vocabularies/urn:cspace:name(deaccessionreason)/items"

Dependencies for merging? Releasing to production?
Will need to be added to other profiles, maybe should just be done now?

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter rebuilt and saw the new term lists in the db

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 19271ce into collectionspace:master Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants