Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duty of Care Updates #289

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

mikejritter
Copy link
Contributor

@mikejritter mikejritter commented Jul 29, 2024

What does this do?

  • Fix pluralization for duty of care
  • Change title to dutyOfCareTitle

Why are we doing this? (with JIRA link)
Jira: https://collectionspace.atlassian.net/browse/DRYD-1332

These changes come from the testing done against Duty of Care. The pluralization update which was requested is being applied here for consistency throughout the procedure.

I also noticed that the title field exists in the dublin core schema, which was sometimes being pulled back in the search results, so I've updated the field definition to be dutyOfCareTitle to avoid that collision. I saw some procedures use services-schema-qualift with their title field, but I'm not too familiar with what that's doing so I did a quick update of the name. Other NAGPRA procedures will likely hit the same issue so if that's simpler it might be a better fix.

How should this be tested? Do these changes have associated tests?

  • Rebuild and start collectionspace
  • Test that the Duty of Care service is accessible on the new uri
curl --user '[email protected]:Administrator' http://localhost:8180/cspace-services/dutiesofcare

Dependencies for merging? Releasing to production?
None

Has the application documentation been updated for these changes?
No

Did someone actually run this code to verify it works?
@mikejritter tested against a local instance

@ray-lee
Copy link
Collaborator

ray-lee commented Jul 30, 2024

Putting services-schema-qualify="true" on title would probably fix it, but I'm fine with changing the name.

Copy link
Collaborator

@ray-lee ray-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ray-lee ray-lee merged commit 33377d5 into collectionspace:master Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants